tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
552 stars 416 forks source link

A slash character in a TriggerBinding value does not work. #1611

Closed ggallen closed 1 year ago

ggallen commented 1 year ago

Expected Behavior

Trying to use a label containing a forward slash (/) in a TriggerBinding JSONPath value does not work.

Actual Behavior

The label value is retrieved correctly and the trigger fires.

Steps to Reproduce the Problem

  1. Binding for the trigger:
    
    bindings:
    - kind: TriggerBinding
    name: instance
    value: $(body.build.metadata.labels['agogos.redhat.com/instance'])

...

template: spec: params:

Additional Info

Pipelines: v0.47.2 Triggers: v0.24.1

khrm commented 1 year ago

After escaping the key, I don't get this error.


  - name: instance
    value: $(body.build.metadata.labels['agogos\.redhat\.com\/instance'])
``
khrm commented 1 year ago

I will create a documentation for this.