Closed khrm closed 4 months ago
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/interceptors/interceptors.go | 89.1% | 89.4% | 0.2 |
/kind bug
/test pull-tekton-triggers-integration-tests
/test pull-tekton-triggers-integration-tests
@khrm Do you want me to take this on, I have some time just now.
Not quite sure what you mean by https://github.com/tektoncd/triggers/pull/1615#pullrequestreview-1595311625 ?
Sorry, @bigkevmcd. I didn't see your message. I just saw it today.
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/interceptors/interceptors.go | 89.1% | 89.4% | 0.2 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dibyom
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Content-Type
should be passed to the interceptor while making the POST Request. Some frameworks in different languages like Java require this. So interceptor request fails with 415 in those.Fixes #1614
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes