khrm commented 1 year ago

Content-Type should be passed to the interceptor while making the POST Request. Some frameworks in different languages like Java require this. So interceptor request fails with 415 in those.

Fixes #1614

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Now `Content-Type: application/json` is passed to the interceptor while making the request.

tekton-robot commented 1 year ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	89.1%	89.4%	0.2

khrm commented 1 year ago

/kind bug

khrm commented 1 year ago

/test pull-tekton-triggers-integration-tests

khrm commented 1 year ago

/test pull-tekton-triggers-integration-tests

bigkevmcd commented 7 months ago

@khrm Do you want me to take this on, I have some time just now.

Not quite sure what you mean by https://github.com/tektoncd/triggers/pull/1615#pullrequestreview-1595311625 ?

khrm commented 5 months ago

Sorry, @bigkevmcd. I didn't see your message. I just saw it today.

tekton-robot commented 5 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/interceptors/interceptors.go	89.1%	89.4%	0.2

tekton-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tektoncd / triggers

Pass Content-Type Header to Interceptor #1615

Changes

Submitter Checklist

Release Notes