Closed khrm closed 1 year ago
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/apis/triggers/v1beta1/event_listener_validation.go | 97.2% | 97.2% | -0.1 |
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/apis/triggers/v1alpha1/event_listener_validation.go | 97.1% | 97.2% | 0.1 |
pkg/apis/triggers/v1beta1/event_listener_validation.go | 97.2% | 97.3% | 0.1 |
@khrm @dibyom PR is ready to review
I have added unit test and updated doc as well
PTAL Thank you
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/apis/triggers/v1alpha1/event_listener_validation.go | 97.1% | 97.2% | 0.1 |
pkg/apis/triggers/v1beta1/event_listener_validation.go | 97.2% | 97.3% | 0.1 |
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/apis/triggers/v1alpha1/event_listener_validation.go | 97.1% | 97.2% | 0.1 |
pkg/apis/triggers/v1beta1/event_listener_validation.go | 97.2% | 97.3% | 0.1 |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dibyom
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Actually, only the first two commits need to be squashed. The last one deals with something else. So it's okay I think.
/lgtm
@khrm: you cannot LGTM your own PR.
@savitaashture Probably, you will need to give lgtm here.
Or open another pr and I will give lgtm.
/close @savitaashture Will open another pr.
Opened PR here https://github.com/tektoncd/triggers/pull/1633
We can set liveness, readiness and start probe now in EventListener.
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes