tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
552 stars 416 forks source link

Remove Probes from Disallowed fields in EventListener #1620

Closed khrm closed 1 year ago

khrm commented 1 year ago

We can set liveness, readiness and start probe now in EventListener.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 1 year ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go 97.2% 97.2% -0.1
tekton-robot commented 1 year ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go 97.1% 97.2% 0.1
pkg/apis/triggers/v1beta1/event_listener_validation.go 97.2% 97.3% 0.1
savitaashture commented 1 year ago

@khrm @dibyom PR is ready to review

I have added unit test and updated doc as well

PTAL Thank you

tekton-robot commented 1 year ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go 97.1% 97.2% 0.1
pkg/apis/triggers/v1beta1/event_listener_validation.go 97.2% 97.3% 0.1
tekton-robot commented 1 year ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go 97.1% 97.2% 0.1
pkg/apis/triggers/v1beta1/event_listener_validation.go 97.2% 97.3% 0.1
tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 1 year ago

Actually, only the first two commits need to be squashed. The last one deals with something else. So it's okay I think.

khrm commented 1 year ago

/lgtm

tekton-robot commented 1 year ago

@khrm: you cannot LGTM your own PR.

In response to [this](https://github.com/tektoncd/triggers/pull/1620#issuecomment-1684020430): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 1 year ago

@savitaashture Probably, you will need to give lgtm here.

khrm commented 1 year ago

Or open another pr and I will give lgtm.

khrm commented 1 year ago

/close @savitaashture Will open another pr.

savitaashture commented 1 year ago

Opened PR here https://github.com/tektoncd/triggers/pull/1633