tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
552 stars 416 forks source link

Change Leader Election Config Map for Controllers and Webhook #1624

Closed khrm closed 1 year ago

khrm commented 1 year ago

Currently, it assumes default configmap config-leader-election which is also used by Tekton Pipelines controller. If someone changes pipelines controller configmap, it changes triggers also.

Fixes: #1623

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
dibyom commented 1 year ago

Do we need separate configs for controller and webhook?

khrm commented 1 year ago

@dibyom Yes. Otherwise, webhook also has the same number of leases as controllers.

savitaashture commented 1 year ago

/lgtm

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment