Closed mike-sirs closed 1 year ago
@mike-sirs Didn't we remove it here? https://github.com/tektoncd/triggers/commit/c366270ccd9c6ad118eec4ff791cb360bdbf492f
Can someone make a new release with that fix?
We will do a v0.25 next week or the week after next.
/assign @savitaashture
@khrm the issues still persist, the PR you've mentioned removed Dynamic
from eventlistenersink/main.go
while the problem is with
https://github.com/tektoncd/triggers/blob/cc1b7b73f165e9480f0cd92ac0b0f36e0f0be3e0/pkg/client/injection/client/client.go#L51C2-L51C64
/go/pkg/mod/github.com/tektoncd/triggers@v0.25.0/pkg/client/injection/client/client.go:51:12: undefined: injection.Dynamic
go.mod:
github.com/tektoncd/pipeline v0.50.1
github.com/tektoncd/triggers v0.25.0
knative.dev/pkg v0.0.0-20230718152110-aef227e72ead
could someone look at this, please?
Knative dropped dynamic wrapped client generation
it results in a compile error
triggers@v0.24.1/pkg/client/injection/client/client.go:51:12: undefined: injection.Dynamic
Steps to Reproduce the Problem
update to knative.dev/pkg v0.0.0-20230815132840-4f651e092853
related issue
https://github.com/knative/pkg/issues/2739