tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
552 stars 416 forks source link

Fix SA1019 error by staticcheck due to deprecation #1629

Closed khrm closed 1 year ago

khrm commented 1 year ago

Fix SA1019 error given by staticcheck due to deprecation of Pipeline v1beta1.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
savitaashture commented 1 year ago

The failures when bumped to Pipeline 0.50.x(LTS) https://github.com/tektoncd/triggers/pull/1625

pkg/apis/triggers/v1alpha1/trigger_template_validation_test.go:211:41: SA1019: pipelinev1beta1.PipelineRun is deprecated: Please use v1.PipelineRun instead. (staticcheck)
                    RawExtension: test.RawExtension(t, pipelinev1beta1.PipelineRun{
tekton-robot commented 1 year ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resources/create.go 81.2% 68.8% -12.5
tekton-robot commented 1 year ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
test/resources.go 42.9% 46.7% 3.8
khrm commented 1 year ago

/assign @dibyom

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom,savitaashture] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
savitaashture commented 1 year ago

/lgtm