tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
552 stars 416 forks source link

Bump knative/pkg to 1.11 #1630

Closed savitaashture closed 1 year ago

savitaashture commented 1 year ago

Changes

Bump knative/pkg to the latest, 1.11

This also updates the min kubernetes version to 1.25.

Bumped knative pkg version as part of this issue https://github.com/tektoncd/triggers/issues/1628

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from savitaashture after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 1 year ago

Elaborating that:

Doing this can cause a potential mismatch for the minimum version of k8s needed between Pipelines and Triggers.

Similarly, we never update the k8s API in Pipelines. They come from Knative.

savitaashture commented 1 year ago

Doing this can cause a potential mismatch for the minimum version of k8s needed between Pipelines and Triggers.

I think with this update both pipeline and Triggers will have kubernetes version as 1.25.

savitaashture commented 1 year ago

@savitaashture We shouldn't update knative directly. We should only bump the pipeline and it will bump the knative.

Right bumping to 0.50.1 will bump knative version to https://github.com/tektoncd/pipeline/blob/release-v0.50.x/go.mod#L37

But i referred @vdemeester PR https://github.com/tektoncd/pipeline/pull/6975 related to knative pkg issue

khrm commented 1 year ago

Yes. In this case, doing this will cause the Triggers min k8s version to be 1.25 which is higher than Pipelines v0.50.

BTW, #1628 is resolved by https://github.com/tektoncd/triggers/commit/c366270ccd9c6ad118eec4ff791cb360bdbf492f which will be shipped in the v0.25 release. That's why I assigned you.

khrm commented 1 year ago

So I think we can close this?

tekton-robot commented 1 year ago

@savitaashture: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-tekton-triggers-build-tests 0625e1c55ecf40da220fed3cd5e8ab22616e47a1 link true /test pull-tekton-triggers-build-tests
pull-tekton-triggers-unit-tests 0625e1c55ecf40da220fed3cd5e8ab22616e47a1 link true /test tekton-triggers-unit-tests
pull-tekton-triggers-integration-tests 0625e1c55ecf40da220fed3cd5e8ab22616e47a1 link true /test pull-tekton-triggers-integration-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
savitaashture commented 1 year ago

So I think we can close this?

Yes