Closed savitaashture closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To complete the pull request process, please ask for approval from savitaashture after the PR has been reviewed.
The full list of commands accepted by this bot can be found here.
Elaborating that:
Doing this can cause a potential mismatch for the minimum version of k8s needed between Pipelines
and Triggers
.
Similarly, we never update the k8s API in Pipelines
. They come from Knative
.
Doing this can cause a potential mismatch for the minimum version of k8s needed between
Pipelines
andTriggers
.
I think with this update both pipeline and Triggers will have kubernetes version as 1.25.
@savitaashture We shouldn't update knative directly. We should only bump the pipeline and it will bump the knative.
Right bumping to 0.50.1 will bump knative version to https://github.com/tektoncd/pipeline/blob/release-v0.50.x/go.mod#L37
But i referred @vdemeester PR https://github.com/tektoncd/pipeline/pull/6975 related to knative pkg issue
Yes. In this case, doing this will cause the Triggers
min k8s version to be 1.25 which is higher than Pipelines
v0.50.
BTW, #1628 is resolved by https://github.com/tektoncd/triggers/commit/c366270ccd9c6ad118eec4ff791cb360bdbf492f which will be shipped in the v0.25 release. That's why I assigned you.
So I think we can close this?
@savitaashture: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-tekton-triggers-build-tests | 0625e1c55ecf40da220fed3cd5e8ab22616e47a1 | link | true | /test pull-tekton-triggers-build-tests |
pull-tekton-triggers-unit-tests | 0625e1c55ecf40da220fed3cd5e8ab22616e47a1 | link | true | /test tekton-triggers-unit-tests |
pull-tekton-triggers-integration-tests | 0625e1c55ecf40da220fed3cd5e8ab22616e47a1 | link | true | /test pull-tekton-triggers-integration-tests |
Full PR test history. Your PR dashboard.
So I think we can close this?
Yes
Changes
Bump knative/pkg to the latest, 1.11
This also updates the min kubernetes version to 1.25.
Bumped knative pkg version as part of this issue https://github.com/tektoncd/triggers/issues/1628
/kind misc
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes