tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
552 stars 416 forks source link

Add probes support in Triggers eventlistener #1633

Closed savitaashture closed 1 year ago

savitaashture commented 1 year ago

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

Triggers now support probes setting on EventListener object
Triggers now have default value for failure-threshold as 3 for both readiness and liveness probes
tekton-robot commented 1 year ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go 97.1% 97.3% 0.2
pkg/apis/triggers/v1beta1/event_listener_validation.go 97.2% 97.4% 0.1
savitaashture commented 1 year ago

/hold

tekton-robot commented 1 year ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/triggers/v1alpha1/event_listener_validation.go 97.1% 97.2% 0.1
pkg/apis/triggers/v1beta1/event_listener_validation.go 97.2% 97.3% 0.1
savitaashture commented 1 year ago

/lgtm

Also, add the point about default failure threshold in the release note.

Added

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [khrm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
savitaashture commented 1 year ago

/test tekton-triggers-unit-tests