search

tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
552 stars 416 forks source link

Knative undefined: injection.Dynamic #1639

Closed mike-sirs closed 3 months ago

mike-sirs commented 12 months ago

Knative dropped dynamic wrapped client generation

closed issue https://github.com/tektoncd/triggers/issues/1628

@khrm the issues still persist, the PR you've mentioned removed Dynamic from eventlistenersink/main.go while the problem is with
https://github.com/tektoncd/triggers/blob/cc1b7b73f165e9480f0cd92ac0b0f36e0f0be3e0/pkg/client/injection/client/client.go#L51C2-L51C64

/go/pkg/mod/github.com/tektoncd/triggers@v0.25.0/pkg/client/injection/client/client.go:51:12: undefined: injection.Dynamic

go.mod:
    github.com/tektoncd/pipeline v0.50.1
    github.com/tektoncd/triggers v0.25.0
        knative.dev/pkg v0.0.0-20230718152110-aef227e72ead

could someone look at this, please?

https://github.com/knative/pkg/issues/2739

khrm commented 12 months ago

Sure, I would remove this.

khrm commented 12 months ago

/assign @khrm

khrm commented 7 months ago

@mike-sirs Can you pick this up?

khrm commented 7 months ago

/help-wanted

mike-sirs commented 7 months ago

/assign @mike-sirs

mike-sirs commented 7 months ago

@khrm https://github.com/tektoncd/triggers/pull/1687

khrm commented 5 months ago

@mike-sirs This is done now. Should be part of the next release.

khrm commented 3 months ago

I closed this as the issue should be resolved by now.