tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
552 stars 416 forks source link

Fix bitbucket server example when both SSH and HTTPS enabled #1641

Closed khrm closed 11 months ago

khrm commented 11 months ago

Fix the bitbucket server example when it has both SSH and HTTPS.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
khrm commented 11 months ago

/kind bug

khrm commented 11 months ago

/retest

Build tests shouldn't fail. The integration test failing is correct.

khrm commented 11 months ago

/retest

savitaashture commented 11 months ago

/lgtm

dibyom commented 11 months ago

fixes #1640

dibyom commented 11 months ago

/approve

tekton-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment