Closed savitaashture closed 8 months ago
What would happen if some resource already exists with that version? Don't we need a conversion function?
Its not needed because it works for both resourceTemplates
and resourcetemplates
i have verified
What would happen if some resource already exists with that version? Don't we need a conversion function?
Its not needed because it works for both
resourceTemplates
andresourcetemplates
i have verified
It's working because go default JSON decoder/encoder doesn't care about case or characters like _
. So etcd would have two different field names after this pr - older with resourcetemplates
and newly created with resourceTemplates
.
What would happen if some resource already exists with that version? Don't we need a conversion function?
Its not needed because it works for both
resourceTemplates
andresourcetemplates
i have verifiedIt's working because go default JSON decoder/encoder doesn't care about case or characters like
_
. So etcd would have two different field names after this pr - older withresourcetemplates
and newly created withresourceTemplates
.
Yes but I think that should be fine right
This seems like the right thing to do - as long as this is not a breaking change i.e. the old style works too
Hi @dibyom @khrm if PR looks good can you guys review and merge it Thank you
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: khrm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
As per the standards the JSON or YAML keys should follow capitalization but resourcetemplates keys doesn't follow that. Changing resourcetemplates to resourceTemplates
Signed-off-by: Savita Ashture sashture@redhat.com"
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes