tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
556 stars 417 forks source link

Update triggers core interceptor to create secret when necessary #1667

Closed savitaashture closed 10 months ago

savitaashture commented 11 months ago

The core interceptor will create secrets in only 2 cases:

  1. when there is no secret present in the cluster.
  2. when certificates expire within the existing secret.

If secret exist and have valid certificates no need to recreate secret everytime

Signed-off-by: Savita Ashture sashture@redhat.com

Fixes : https://github.com/tektoncd/triggers/issues/1638

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 11 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/server/server.go Do not exist 80.6%
tekton-robot commented 11 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/server/server.go 79.7% 80.6% 0.9
khrm commented 11 months ago

/assign @dibyom

/approve

Let's get this merge.

tekton-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [khrm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dibyom commented 10 months ago

/lgtm

savitaashture commented 10 months ago

/cherry-pick release-v0.25.x

tekton-robot commented 10 months ago

@savitaashture: new pull request created: #1673

In response to [this](https://github.com/tektoncd/triggers/pull/1667#issuecomment-1812864656): >/cherry-pick release-v0.25.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.