Closed savitaashture closed 10 months ago
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/interceptors/server/server.go | Do not exist | 80.6% |
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/interceptors/server/server.go | 79.7% | 80.6% | 0.9 |
/assign @dibyom
/approve
Let's get this merge.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: khrm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/cherry-pick release-v0.25.x
@savitaashture: new pull request created: #1673
The core interceptor will create secrets in only 2 cases:
If secret exist and have valid certificates no need to recreate secret everytime
Signed-off-by: Savita Ashture sashture@redhat.com
Fixes : https://github.com/tektoncd/triggers/issues/1638
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes