tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
546 stars 416 forks source link

Disable HTTP/2 for webhoook by updating Knative #1672

Closed khrm closed 8 months ago

khrm commented 8 months ago

This disables HTTP/2 for webhook by updating to PR knative/pkg#2875 It fixes CVE-2023-44487.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

Disable webhook for http2.
tekton-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
savitaashture commented 8 months ago

/lgtm

savitaashture commented 8 months ago

/cherry-pick release-v0.25.x

tekton-robot commented 8 months ago

@savitaashture: once the present PR merges, I will cherry-pick it on top of release-v0.25.x in a new PR and assign it to you.

In response to [this](https://github.com/tektoncd/triggers/pull/1672#issuecomment-1812868148): >/cherry-pick release-v0.25.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 8 months ago

@savitaashture: new pull request created: #1675

In response to [this](https://github.com/tektoncd/triggers/pull/1672#issuecomment-1812868148): >/cherry-pick release-v0.25.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.