tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
546 stars 416 forks source link

Add string translation to CEL interceptor. #1686

Closed bigkevmcd closed 5 months ago

bigkevmcd commented 5 months ago

Changes

This adds a new "translate" function to the CEL interceptor library that allows using a regular expression to translate replacement characters to specified strings.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

New `translate` function added to the CEL interceptor.
bigkevmcd commented 5 months ago

/kind feature

tekton-robot commented 5 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 89.7% 88.2% -1.5
tekton-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [savitaashture] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tekton-robot commented 5 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 89.7% 88.2% -1.5
savitaashture commented 5 months ago

@bigkevmcd can you rebase the PR

tekton-robot commented 5 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/interceptors/cel/triggers.go 89.7% 88.2% -1.5