tektoncd / triggers

Event triggering with Tekton!

Apache License 2.0

556 stars 417 forks source link

1639 dynamic wrapped client #1687

Closed mike-sirs closed 8 months ago

mike-sirs commented 8 months ago

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

release-note:

go 1.21
remove go.mod versions fix
bump knative.dev
dependencies update

linux-foundation-easycla[bot] commented 8 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: mike-sirs / name: Mike Sirs (399cf830f79cd8919449300c16acc282c18bda3b, 567de37e904d0dcd9a90da671b40282f630865f4, 4f525ee5b075da578363b6a4e076a9f16b4c5632, 29e891b504b0217e29552529956f85166e5e8b3c)

tekton-robot commented 8 months ago

Hi @mike-sirs. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

tekton-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign khrm after the PR has been reviewed. You can assign the PR to them by writing /assign @khrm in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tekton-robot commented 8 months ago

@mike-sirs: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

mike-sirs commented 8 months ago

@khrm

tekton-robot commented 8 months ago

@mike-sirs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-tekton-triggers-unit-tests	29e891b504b0217e29552529956f85166e5e8b3c	link	true	`/test tekton-triggers-unit-tests`
pull-tekton-triggers-build-tests	29e891b504b0217e29552529956f85166e5e8b3c	link	true	`/test pull-tekton-triggers-build-tests`
pull-tekton-triggers-integration-tests	29e891b504b0217e29552529956f85166e5e8b3c	link	true	`/test pull-tekton-triggers-integration-tests`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

tekton-robot commented 8 months ago

@mike-sirs: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

savitaashture commented 8 months ago

@mike-sirs can you rebase the PR ?

mike-sirs commented 8 months ago

Will do later today

On Mon, Feb 5, 2024, 08:40 savitaashture @.***> wrote:

@mike-sirs https://github.com/mike-sirs can you rebase the PR ?

— Reply to this email directly, view it on GitHub https://github.com/tektoncd/triggers/pull/1687#issuecomment-1927154590, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI4BYG2NFROGONJ77DGZC3YSDVOJAVCNFSM6AAAAABCYIXZIWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRXGE2TINJZGA . You are receiving this because you were mentioned.Message ID: @.***>

khrm commented 7 months ago

@mike-sirs Why did you close this?