tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
546 stars 416 forks source link

Triggers do not include TriggerTemplate labels when creating resources #1689

Closed ggallen closed 5 months ago

ggallen commented 5 months ago

Expected Behavior

When a TriggerTemplate resource template contains labels, those labels should be included in the created resource.

Actual Behavior

The labels are not included in the created resource.

Steps to Reproduce the Problem

  1. Create a TriggerTemplate with a resourceTemplate that contains labels in the metadata.
  2. Create a Trigger that uses the defined TriggerTemplate.
  3. Cause the trigger to fire and create the resource.

Additional Info

Client Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.10", GitCommit:"0fa26aea1d5c21516b0d96fea95a77d8d429912e", GitTreeState:"clean", BuildDate:"2024-01-17T13:46:28Z", GoVersion:"go1.20.13", Compiler:"gc", Platform:"linux/amd64"}
Kustomize Version: v5.0.1
Server Version: version.Info{Major:"1", Minor:"27", GitVersion:"v1.27.10", GitCommit:"0fa26aea1d5c21516b0d96fea95a77d8d429912e", GitTreeState:"clean", BuildDate:"2024-01-17T13:38:41Z", GoVersion:"go1.20.13", Compiler:"gc", Platform:"linux/amd64"}
savitaashture commented 5 months ago

Hi @ggallen :wave:

I see its an issue with Pipeline I mean even if you try directly customRun without using Triggers you face the same issue

So can you create an issue in Pipeline?

ggallen commented 5 months ago

Superseded by https://github.com/tektoncd/pipeline/issues/7639.