Closed savitaashture closed 5 months ago
Please write in release note also.
/kind bug
Also, update the release and mention this in Release of v0.26.0
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dibyom
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/cherry-pick release-v0.26.x
@savitaashture: new pull request created: #1694
Also, update the release and mention this in Release of v0.26.0
@khrm i have updated https://github.com/tektoncd/triggers/releases/tag/v0.26.0 PTAL
This reverts commit 447f613dd1731181e40ada3d9141548b45bbdb2c.
Reason:
Reverting this PR because altering the tag will impact the upgrade flow. The existing TriggerTemplate data with the old tag still persists in etcd. Consequently, during an upgrade with the new tag, the data isn't fetched for the trigger template as expected.
We'll revert this PR for now and reintroduce the change when we support the new ApiVersion. At that point, we'll utilize conversion functionality (convertTo and convertFrom) to ensure seamless transition. By incorporating the ApiVersion, we'll be able to adjust the tag accordingly.
Fixes: https://github.com/tektoncd/triggers/issues/1690
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes