tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
546 stars 416 forks source link

Revert "Follow naming conventions for resourceTemplates" #1693

Closed savitaashture closed 5 months ago

savitaashture commented 5 months ago

This reverts commit 447f613dd1731181e40ada3d9141548b45bbdb2c.

Reason:

Reverting this PR because altering the tag will impact the upgrade flow. The existing TriggerTemplate data with the old tag still persists in etcd. Consequently, during an upgrade with the new tag, the data isn't fetched for the trigger template as expected.

We'll revert this PR for now and reintroduce the change when we support the new ApiVersion. At that point, we'll utilize conversion functionality (convertTo and convertFrom) to ensure seamless transition. By incorporating the ApiVersion, we'll be able to adjust the tag accordingly.

Fixes: https://github.com/tektoncd/triggers/issues/1690

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
khrm commented 5 months ago

Please write in release note also.

/kind bug

khrm commented 5 months ago

Also, update the release and mention this in Release of v0.26.0

dibyom commented 5 months ago

/approve

tekton-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
savitaashture commented 5 months ago

/cherry-pick release-v0.26.x

tekton-robot commented 5 months ago

@savitaashture: new pull request created: #1694

In response to [this](https://github.com/tektoncd/triggers/pull/1693#issuecomment-1934563277): >/cherry-pick release-v0.26.x Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
savitaashture commented 5 months ago

Also, update the release and mention this in Release of v0.26.0

@khrm i have updated https://github.com/tektoncd/triggers/releases/tag/v0.26.0 PTAL