nicolasbernard commented 3 months ago

Changes

Add the ability to define the service spec.loadBalancerClass for EventListener with a Service of type LoadBalancer.

It's useful if your cluster has multiples LoadBalancer controllers and you need to choose on which one you want to expose the EventListener, for example you can have one controller for public IPs and another for privates IPs.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

[x] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[x] Has Tests included if any functionality added or changed
[x] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[x] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

EventListners have a new field letting you choose on which LoadBalancer you want to expose the underlying service if you have severals.

linux-foundation-easycla[bot] commented 3 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: nicolasbernard / name: Nicolas BERNARD (e94f8f58b9be61d42f50cd1fa4b226c82dddc1bb)

tekton-robot commented 3 months ago

Hi @nicolasbernard. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

nicolasbernard commented 3 months ago

/kind feature

khrm commented 3 months ago

@nicolasbernard Please sign the cla.

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.3%	97.4%	0.0

nicolasbernard commented 3 months ago

@nicolasbernard Please sign the cla.

I did, at least I tried, if the bot didn't update, it means I did something wrong?

Edit: Should be good.

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.3%	97.4%	0.0

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.3%	97.4%	0.0

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.3%	97.4%	0.0

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.3%	97.4%	0.0

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.3%	97.4%	0.0

savitaashture commented 3 months ago

/assign @dibyom @khrm

tekton-robot commented 3 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.3%	97.4%	0.0

tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [savitaashture] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/apis/triggers/v1beta1/event_listener_validation.go	97.3%	97.4%	0.0

nicolasbernard commented 2 months ago

@khrm Should be good, thanks you for making it happen :)

tektoncd / triggers

Add LoadBalancerClass support in EventListener #1708

Changes

Submitter Checklist

Release Notes