tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
545 stars 416 forks source link

Node port service match kubernetes resource #1716

Closed jmcshane closed 2 months ago

jmcshane commented 3 months ago

Closes #1586

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

Resolve node port when serviceType is NodePort
khrm commented 3 months ago

/kind feature

tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom, khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom,khrm] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment