tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
545 stars 416 forks source link

Bump go to 1.21 and pipeline to v0.59.0 LTS #1722

Closed khrm closed 2 months ago

khrm commented 2 months ago

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

Update Go version to 1.21 and Pipelines to v0.59.0. Minimum Kubernetes version is 1.27.
khrm commented 2 months ago

/assign @savitaashture

khrm commented 2 months ago

/test tekton-triggers-unit-tests

khrm commented 2 months ago

It seems I need to update test go version.

khrm commented 2 months ago

Should be fixed by https://github.com/tektoncd/plumbing/pull/1938

khrm commented 2 months ago

/retest

khrm commented 2 months ago

We also need to change replace in go.mod file.

dibyom commented 2 months ago

/test pull-tekton-triggers-build-tests

khrm commented 2 months ago

/test pull-tekton-triggers-build-tests

khrm commented 2 months ago

/test tekton-triggers-unit-tests

khrm commented 2 months ago

/test pull-tekton-triggers-build-tests

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 23.2% 24.1% 0.9
tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 23.2% 24.1% 0.9
khrm commented 2 months ago

/test pull-tekton-triggers-integration-tests

khrm commented 2 months ago

/test pull-tekton-triggers-build-tests

khrm commented 2 months ago

"error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8) " Not sure why we are getting this.

khrm commented 2 months ago

/retest-required

tekton-robot commented 2 months ago

The following is the coverage report on the affected files. Say /test pull-tekton-triggers-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/adapter/adapter.go 23.2% 24.1% 0.9
khrm commented 2 months ago

@savitaashture Can you review this?

tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [savitaashture] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment