tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
545 stars 416 forks source link

Fix is-multi-ns flag for triggerGroups #1725

Closed seternate closed 2 months ago

seternate commented 2 months ago

Changes

Fix that the --is-multi-ns flag on the eventlistener is set to true, when using a namespaceSelector on any triggerGroup.

Fixes https://github.com/tektoncd/triggers/issues/1652 Fixes https://github.com/tektoncd/triggers/issues/1617 Fixes https://github.com/tektoncd/triggers/issues/1700

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

Fix that the --is-multi-ns flag on the eventlistener is set to true, when using a namespaceSelector on any triggerGroup.
seternate commented 2 months ago

/kind bug

tekton-robot commented 2 months ago

Hi @seternate. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
khrm commented 2 months ago

We can ignore above tests failure. That's fixed by other PR.

khrm commented 2 months ago

/test pull-tekton-triggers-build-tests

tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: khrm, savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [khrm,savitaashture] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 2 months ago

/lgtm