tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
556 stars 417 forks source link

Why not to specify TriggerTemplate as resource type? #1726

Closed dancer1325 closed 5 months ago

dancer1325 commented 7 months ago

Expected Behavior

Specify clearly that 'TriggerTemplate' is a resource under the package 'triggers.tekton.dev/v1beta1', since it's a standalone CR

Resource Types: ClusterTriggerBinding EventListener Trigger TriggerBinding TriggerTemplate

Actual Behavior

'TriggerTemplate' is NOT specified clearly as a CR

Resource Types: ClusterTriggerBinding EventListener Trigger TriggerBinding

Steps to Reproduce the Problem

  1. Navigate to https://tekton.dev/docs/triggers/triggers-api/#triggers.tekton.dev/v1beta1

Additional Info

AlanGreene commented 7 months ago

Thanks for reporting this @dancer1325

tektoncd/triggers would be the right place for this, @dibyom can you transfer the issue please?

dibyom commented 5 months ago

cc @khrm @savitaashture - this looks like a missing tag somewhere?

khrm commented 5 months ago

The Tag was there. Not sure why it requires a new line before it. https://github.com/tektoncd/triggers/pull/1727/files#diff-b298db60f09e46c7935921f4e629ae4066da95202fccdfb1fd42b11b4ede776f

khrm commented 5 months ago

/assign @khrm