tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
545 stars 416 forks source link

Update ko to 0.15.1 and Go to go1.22.2 for publish task #1731

Closed khrm closed 2 months ago

khrm commented 2 months ago

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
khrm commented 2 months ago

It's difficult to find go version from container registry, that's why I decided to use latest image sha

khrm commented 2 months ago

/assign @savitaashture @dibyom

savitaashture commented 2 months ago

Based on you PR title How do we ensure its ko 0.15.1 & go1.22.2?

khrm commented 2 months ago

By running the container with the image and checking version inside it.

tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [savitaashture] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 2 months ago

@dibyom Can you merge this?

savitaashture commented 2 months ago

/lgtm