Open luoyucumt opened 1 month ago
@luoyucumt: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign savitaashture after the PR has been reviewed.
You can assign the PR to them by writing /assign @savitaashture
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Hi @luoyucumt. Thanks for your PR.
I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/sink/sink.go | 71.1% | 70.7% | -0.3 |
pkg/template/event.go | 100.0% | 53.6% | -46.4 |
@luoyucumt: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-tekton-triggers-unit-tests | cafc40c9d10082894f5bbf4858ddb6d373caba8c | link | true | /test tekton-triggers-unit-tests |
Full PR test history. Your PR dashboard.
Implementation of Feature Request: Issue #1474
This PR introduces changes that address the functionality requested in Issue #1474. The enhancements align with the needs specified in the issue, providing a more flexible and robust triggers setup.