tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
545 stars 416 forks source link

Set readOnlyRootFilesystem as true in Controller and Webhook #1735

Closed khrm closed 6 days ago

khrm commented 1 month ago

Setting Controller's Deployment security context readOnlyRootFilesystem to true to increase the security and to avoid being flagged by the security scanner.

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

Controller's and Webhook's Deployment security context `readOnlyRootFilesystem`  are set to true to increase the security and to avoid being flagged by the security scanner.
savitaashture commented 1 month ago

Should we add readOnlyRootFilesystem to EL deployment as well?

khrm commented 1 month ago

We need that via a configuration not only yaml.

savitaashture commented 1 month ago

We need that via a configuration not only yaml.

Yup i was also thinking the same

I was assuming that change should be part of this PR so added review comment

tekton-robot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
khrm commented 6 days ago

@savitaashture We can merge this now. There's a pr for EL now.

savitaashture commented 6 days ago

@savitaashture We can merge this now. There's a pr for EL now.

Sure

savitaashture commented 6 days ago

/lgtm