Closed savitaashture closed 1 month ago
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/apis/config/default.go | 92.3% | 51.9% | -40.5 |
pkg/reconciler/eventlistener/eventlistener.go | 71.3% | 71.5% | 0.2 |
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/apis/config/default.go | 92.3% | 81.5% | -10.8 |
pkg/reconciler/eventlistener/eventlistener.go | 71.3% | 71.5% | 0.2 |
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/apis/config/default.go | 92.3% | 88.9% | -3.4 |
pkg/reconciler/eventlistener/eventlistener.go | 71.3% | 71.5% | 0.2 |
One nit and looks like we need to fix the yaml files. Otherwise, LGTM
pkg/apis/config/testdata/config-defaults-triggers-empty-val.yaml
24:1 error too many blank lines (1 > 0) (empty-lines)
pkg/apis/config/testdata/config-defaults-triggers.yaml
24:1 error too many blank lines (1 > 0) (empty-lines)
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dibyom
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The following is the coverage report on the affected files.
Say /test pull-tekton-triggers-go-coverage
to re-run this coverage report
File | Old Coverage | New Coverage | Delta |
---|---|---|---|
pkg/apis/config/default.go | 92.3% | 88.9% | -3.4 |
pkg/reconciler/eventlistener/eventlistener.go | 71.3% | 71.5% | 0.2 |
@khrm PTAL Thank you
As part of this PR, when the flag
el-security-context
is enabled the securityContext have all configuration except RunAsUser and RunAsGroupAdded new fields
default-run-as-user
anddefault-run-as-group
toconfig-defaults-triggers
configmap so that RunAsUser and RunAsGroup can be now configured through CMThis change handles cases in environments where user ID 65532 is not allowed, such as OpenShift.
Signed-off-by: Savita Ashture sashture@redhat.com
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes