tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
545 stars 416 forks source link

Update eventlistener podSeurityContext to adhere to restricted pod se… #1740

Open kristofferchr opened 1 week ago

kristofferchr commented 1 week ago

Solves issue #1739

Currently, when el-security-context is enabled, the securityContext for EventListener in the pod template only sets runAsNonRoot. Expanding podTemplate securityContext can make it easier to fulfill restricted pod security standards.

Makes it possible to have a default securityContext set for injected sidecar containers that does not fulfill restricted pod security standars. An example of this is injected istio containers.

Changes

Alter podSecurityContext to include seccompProfile, runAsUser, runAsGroup and fsGroup when set-security-context is set.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

Eventlistener podTemplate now includes securityContext settings: seccompProfile, runAsUser, runAsGroup, and fsGroup when flag el-security-context is true. 
tekton-robot commented 1 week ago

Hi @kristofferchr. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign dibyom after the PR has been reviewed. You can assign the PR to them by writing /assign @dibyom in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
linux-foundation-easycla[bot] commented 1 week ago

CLA Signed

The committers listed above are authorized under a signed CLA.

kristofferchr commented 1 week ago

/kind feature

kristofferchr commented 1 week ago

/retest

kristofferchr commented 1 week ago

/retest

tekton-robot commented 1 day ago

@kristofferchr: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.