Closed savitaashture closed 6 days ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: khrm
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold
/hold cancel
Submitting review comment by mistake LGTM and approve comment also. That's why I put it to hold temporarily.
@savitaashture: PR needs rebase.
/test pull-tekton-triggers-build-tests
@savitaashture: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
pull-tekton-triggers-build-tests | 561a3e9d29fe160debdd7c1c177c5f6b9ed7a36b | link | true | /test pull-tekton-triggers-build-tests |
Full PR test history. Your PR dashboard.
closing this behalf of https://github.com/tektoncd/triggers/pull/1745 as there are many conflict cc @khrm
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes