tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
556 stars 417 forks source link

Fixes eventlistener link and cel expression yaml example in docs #1746

Closed danielfbm closed 2 months ago

danielfbm commented 3 months ago

Changes

Eventlistener LoadBalancerClass link with wrong markdown syntax

cel_expression with invalid yaml example

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

Release Notes

NONE
tekton-robot commented 3 months ago

Hi @danielfbm. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
danielfbm commented 3 months ago

/kind documentation

khrm commented 3 months ago

/lgtm

danielfbm commented 3 months ago

sorry, my IDE did more formatting then expected, I will revert some of the formatting changes

danielfbm commented 3 months ago

/hold

danielfbm commented 3 months ago

/unhold

danielfbm commented 2 months ago

@khrm hi~ can you help me to push this forward? not sure what happened with tide πŸ˜…

tekton-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/triggers/blob/main/OWNERS)~~ [dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
danielfbm commented 2 months ago

@khrm can you please check again? thanks

danielfbm commented 2 months ago

@khrm hi~ sorry to bother again, is anything else needed to push this forward? thanks~