search

tektoncd / triggers

Event triggering with Tekton!
Apache License 2.0
557 stars 420 forks source link

Support dry-run in the admission webhook #203

Open afrittoli opened 5 years ago

afrittoli commented 5 years ago

Expected Behavior

I can kubectl diff tekton triggers resources

Actual Behavior

On the plumbing repo:

$ kubectl diff -k tekton/resources
Error from server (InternalError): Internal error occurred: admission webhook "triggers-webhook.tekton.dev" does not support dry run
andreafrittoli@galadriel:/go/src/github.com/tektoncd/plumbing (buildid)$ ll tekton/resources/
total 96
drwxr-xr-x  11 andreafrittoli  wheel   352  2 Nov 17:24 .
drwxr-xr-x   8 andreafrittoli  wheel   256 31 Oct 15:40 ..
-rw-r--r--   1 andreafrittoli  wheel  3039  2 Nov 17:24 image-build-trigger.yaml
-rw-r--r--   1 andreafrittoli  wheel  5669 23 Oct 11:08 install_and_test_tekton_release.yaml
-rw-r--r--   1 andreafrittoli  wheel  6915 23 Oct 11:08 install_tekton_release.yaml
-rw-r--r--   1 andreafrittoli  wheel   304 31 Oct 15:18 kustomization.yaml
-rw-r--r--   1 andreafrittoli  wheel  3877 24 Oct 16:55 pipeline-nightly-build-trigger.yaml
-rw-r--r--   1 andreafrittoli  wheel  1923 24 Oct 16:55 pipeline-nightly-release-logs-trigger.yaml
-rw-r--r--   1 andreafrittoli  wheel  2965 23 Oct 11:08 prerelease_checks.yaml
-rw-r--r--   1 andreafrittoli  wheel  2471 24 Oct 16:55 save-release-logs.yaml
-rw-r--r--   1 andreafrittoli  wheel  5480 23 Oct 11:08 test_tekton_release.yaml

Steps to Reproduce the Problem

1. 2. 3.

Additional Info

tekton-robot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot commented 4 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

tekton-robot commented 4 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot commented 4 years ago

@tekton-robot: Closing this issue.

In response to [this](https://github.com/tektoncd/triggers/issues/203#issuecomment-673156523): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close > >Send feedback to [tektoncd/plumbing](https://github.com/tektoncd/plumbing). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
vdemeester commented 4 years ago

/remove-lifecycle rotten /remove-lifecycle stale /reopen

tekton-robot commented 4 years ago

@vdemeester: Reopened this issue.

In response to [this](https://github.com/tektoncd/triggers/issues/203#issuecomment-673324768): >/remove-lifecycle rotten >/remove-lifecycle stale >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tekton-robot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

vdemeester commented 4 years ago

/remove-lifecycle stale

tekton-robot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

vdemeester commented 3 years ago

/remove-lifecycle stale /lifecycle frozen

mpetason commented 3 years ago

It looks like this issue may have been resolved by updating the webhook yaml config? It doesn't seem like the same error happens when I run it on a more up to date version. It looks like plumbing has other issues where resources is a directory now instead of a yaml file. If I run the same command against triggers it looks like it works.

@afrittoli can you see if this is still an issue and let me know if the steps to reproduce are different? I was looking at working on this if it is still an issue.