tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
63 stars 151 forks source link

Docsy update #336

Closed geriom closed 2 years ago

geriom commented 2 years ago

This is the same as #303. Because of the size of this PR, we are going to test it in this branch first before we merge it to main.

The docsy theme was last updated 2 years ago, a few quality of life improvements have been introduced since then, for example:

Changes

This commit pulls the latest version of the theme from the docsy repo with a few changes to facilitate further updates.

Docsy uses Bootstrap and FontAwesome as git submodules, these are checked in. To decouple the dependencies, I removed the submodules and made them npm dependecies. See the changes in package.json and themes/docsy/assets/scss/main.scss.

I also made some changes in layouts/docs/baseof.html for the site to be compatible with the latest version of the theme.

tekton-updated

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

geriom commented 2 years ago

I fixed the problems we had in #303

tekton-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/website/blob/docsy_update/OWNERS)~~ [afrittoli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
afrittoli commented 2 years ago

/lgtm