tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
63 stars 151 forks source link

Update pipelines.md #375

Closed palladius closed 2 years ago

palladius commented 2 years ago

tkn wasn't installed in my system by following the two getting started, so I'm proposing to point out explicitly where you can install "tkn" CLI. It worked for my on my Mac by executing the two brew commands.

-- ricc@

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

linux-foundation-easycla[bot] commented 2 years ago

CLA Signed

The committers listed above are authorized under a signed CLA.

palladius commented 2 years ago

added EasyCLA as Googler (|ricc)

tekton-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)~~ [afrittoli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
palladius commented 2 years ago

You're right it's up there. I've overlooked the instructions since this was page TWO of the tutorial and I thought I'd installed all dependencies in previous page. When I got the error, I ctrl-F'ed tkn and failed to find it above.

May I at least suggest you change

FROM: Install the Tekton CLI.

TO: Install the Tekton CLI (for tkn command).

? This would make the error ctrl-f-able.

geriom commented 2 years ago

Thank you for the feedback @palladius, I'm adding a clarification note to that point in #377.

I'm closing this PR.