tektoncd / website

Tekton Website

https://tekton.dev

Apache License 2.0

62 stars 149 forks source link

Trying to solve a possible confusion #390

Closed ahmedsameha1 closed 2 years ago

ahmedsameha1 commented 2 years ago

I have waited much time to see ALL entries under the STATUS column showing Running, which has not happened! I have realized that I should watch the name of the component and its corresponding STATUS column state.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[ ] Includes docs (if user facing)
[ ] Commit messages follow commit message best practices

See the contribution guide for more details.

linux-foundation-easycla[bot] commented 2 years ago

:x: - login: @ahmedsameha1 / name: Ahmed Mohamed Sameh . The commit (5966f3bc80daeae6f8dac7493746a5d19ecc7734) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

tekton-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign alangreene You can assign the PR to them by writing /assign @alangreene in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

afrittoli commented 2 years ago

Hello @ahmedsameha1, welcome to the Tekton community, and thank you for your contribution. In order for your PR to be merged, we ask you that you sign the CLA, please follow the instruction below if you would like to do so:

❌ - login: @ahmedsameha1 / name: Ahmed Mohamed Sameh . The commit (5966f3b) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

The watch mode in kubectl shows any change of state incrementally, by displaying a new line every time a change happens. I think the existing text looks ok-ish, perhaps adding an example of the expected output would help to clarify the confusion?

ahmedsameha1 commented 2 years ago

Yes, I think that putting an example would help. If you care, do it. The signing process that you ask me to do is really annoying. Currently, I would not bother doing it.

geriom commented 2 years ago

Thank your for the feedback @ahmedsameha1! I'm incorporating your suggestion and a few other editorial changes in #412