search

tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

Accessibility add link name #399

Closed Arhell closed 2 years ago

Arhell commented 2 years ago

Changes

resolve https://github.com/tektoncd/website/issues/398

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

tekton-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign popcor255 You can assign the PR to them by writing /assign @popcor255 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AlanGreene commented 2 years ago

@Arhell As I mentioned in my previous comment, we should not need the aria-label attribute now that we have the alt text on the images. Can you confirm and close the PR if this is accurate?