tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
63 stars 151 forks source link

fix small jump on open close dropdown #408

Closed Arhell closed 2 years ago

Arhell commented 2 years ago

Changes

resolve https://github.com/tektoncd/website/issues/406 copied sidebar-tree.html and small fix

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

tekton-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign jjasghar after the PR has been reviewed. You can assign the PR to them by writing /assign @jjasghar in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
afrittoli commented 2 years ago

Thanks @Arhell - I'm not sure I see the issue and the difference in the fix. @geriom is working on pulling in a new version of docsy - I wonder if it would be worth fixing such issues upstream instead or if a fix may already be available there?

Arhell commented 2 years ago

Thanks @Arhell - I'm not sure I see the issue and the difference in the fix. @geriom is working on pulling in a new version of docsy - I wonder if it would be worth fixing such issues upstream instead or if a fix may already be available there?

In the new version there is no such problem, he corrected it in due time. If needed, I can help with the update and make a gitsubmodule

geriom commented 2 years ago

Thanks @Arhell. The updated docsy preview is live now here: https://docsy-update--tekton.netlify.app/docs/

Let me know if you something missing. You can open PRs against the update_docsy branch.

Arhell commented 2 years ago

Thanks @Arhell. The updated docsy preview is live now here: https://docsy-update--tekton.netlify.app/docs/

Let me know if you something missing. You can open PRs against the update_docsy branch.

Thanks @Arhell. The updated docsy preview is live now here: https://docsy-update--tekton.netlify.app/docs/

Let me know if you something missing. You can open PRs against the update_docsy branch.

Thank you, no, I looked, everything is ok. I would only recommend updating to version 0.4.0 https://github.com/tektoncd/website/commit/e12f8507e2cfbc4424ce755682c5d72573c0731b#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R5

https://github.com/tektoncd/website/commit/e12f8507e2cfbc4424ce755682c5d72573c0731b#diff-3295df7234525439d778f1b282d146a4f1ff6b415248aaac074e8042d9f42d63R2

you can also tell me how to update these versions, I want to support the site in the future, thanks

I know how to update via git, but unfortunately not via go

geriom commented 2 years ago

you can also tell me how to update these versions, I want to support the site in the future, thanks

I know how to update via git, but unfortunately not via go

I will document the updating process once we merge those changes into main.

Glad to have you as contributor! If you want, you can join the Slack channel and the mailing list , and the weekly Working Group meeting to get more involved in community discussions.