tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

Comment out synced files front matter #429

Closed geriom closed 1 year ago

geriom commented 1 year ago

Changes

Commenting out the front matter allows to reuse that content in other files where it may be relevant using the readfile shortcode. This doesn't affect the normal functionality of the YAML front matter.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

geriom commented 1 year ago

This is one of the Tasks to solve #346

AlanGreene commented 1 year ago

@geriom Looks like the python unit tests are failing as they're not expected the comment

AssertionError: '<!--\n---\ntest1: abc\nweight: 0\n---\n-->\n' != '---\ntest1: abc\nweight: 0\n---\n'

geriom commented 1 year ago

@geriom Looks like the python unit tests are failing as they're not expected the comment

AssertionError: '<!--\n---\ntest1: abc\nweight: 0\n---\n-->\n' != '---\ntest1: abc\nweight: 0\n---\n'

@AlanGreene Updated the PR, tests are passing now.

AlanGreene commented 1 year ago

Thanks @geriom /lgtm

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)~~ [AlanGreene,afrittoli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment