tektoncd / website

Tekton Website

https://tekton.dev

Apache License 2.0

63 stars 151 forks source link

Fix typos and make small improvements #466

Closed geriom closed 1 year ago

geriom commented 1 year ago

Changes

Fix typos and small quality of life improvements:

Typo in heading sentence in triggers getting started
Update links on landing page
Add scrolling and margin to version selector.
Typo in community page, misson instead of mission
Add vertical scrolling to extra-long code samples.
Change RSS button styles to match other buttons styles.

Previews

Code samples with vertical scroll bars:
Version switcher with scroll bars and margin:

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

[x] Includes docs (if user facing)
[x] Commit messages follow commit message best practices

See the contribution guide for more details.

geriom commented 1 year ago

Thank you, @AlanGreene. I updated the PR to address your feedback. TAL

AlanGreene commented 1 year ago

Thanks Geri 😸 /lgtm

alhuizenga commented 1 year ago

/approve

AlanGreene commented 1 year ago

Apologies, I thought this one had already been approved /approve /meow

tekton-robot commented 1 year ago

@AlanGreene: cat image

In response to [this](https://github.com/tektoncd/website/pull/466#issuecomment-1313954214): >Apologies, I thought this one had already been approved >/approve >/meow Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

dibyom commented 1 year ago

/approve

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene, alhuizenga, dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)~~ [AlanGreene,dibyom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment