Closed geriom closed 1 year ago
😮💨 No idea why the build is failing. I'm going to double-check. (cue in the "it works on my machine" meme)
cmdline: git clone -v -- https://github.com/tektoncd/results /opt/build/repo/sync/.cache/results
RPC failed; HTTP 500 curl 22 The requested URL returned error: 500
error: RPC failed; HTTP 500 curl 22 The requested URL returned error: 500
Apparently we have to increase the github buffer size?
Thanks @geriom, this looks great! Would you mind adding a unit test for the changes so that we do not break it in future?
@afrittoli I added a test.
I also noticed that transform_links_doc
lacks the assert statement and that just adding it is not enough. I opened #492 to track that, I saw that you did some work on that and I'm planning to take a closer look, but I'm not sure if this requires a lot of work to fix.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: afrittoli
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Changes
Fixes Triggers diagram not showing on the landing page.
It's not the cleanest solution but it works.
Tekton Triggers landing page preview
/closes #340 /closes #453
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
See the contribution guide for more details.