search

tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

Update OpenShift pipelines-install instruction… #511

Closed vdemeester closed 11 months ago

vdemeester commented 1 year ago

Changes

The current documentation doesn't work with OpenShift because of the securityContext.runAsUser that comes in the way of the default behavior of OpenShift. This fixes that.

Signed-off-by: Vincent Demeester vdemeest@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

vdemeester commented 1 year ago

@afrittoli @geriom to have this fixed in "versionned" docs of pipeline, what is the process ? 👼🏼

geriom commented 1 year ago

@afrittoli @geriom to have this fixed in "versionned" docs of pipeline, what is the process ? 👼🏼

Currently we have to wait until the next release for this to work. Maybe we can build the site from HEAD (the site is rebuilt every night) and from there link to both the latest release and the latest LTS release. Thoughts?

We also need to come up with a way to preview this kind of content ( tracking this in #493 )

vdemeester commented 1 year ago

@geriom what is the status here ? Do we still need to wait for something ?

geriom commented 1 year ago

@vdemeester We can merge this. I'm waiting for someone familiar with OpenShift to approve it.

@afrittoli can you take another look please?

tekton-robot commented 11 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

geriom commented 11 months ago

/remove-lifecycle stale

piyush-garg commented 11 months ago

/lgtm

tekton-robot commented 11 months ago

@piyush-garg: changing LGTM is restricted to collaborators

In response to [this](https://github.com/tektoncd/website/pull/511#issuecomment-1644164365): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
geriom commented 11 months ago

/lgtm

tekton-robot commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geriom, khrm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)~~ [geriom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment