search

tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

Remove metadata.description from show-readme.yaml #529

Closed pavanstarmanwar closed 1 year ago

pavanstarmanwar commented 1 year ago

Changes

show-readme.yaml file contains description which causes following error since description under metadata is an unknown field, removing that line fixed the issue.

Failure:

kubectl apply -f show-readme.yaml
Error from server (BadRequest): error when creating "show-readme.yaml": Task in version "v1beta1" cannot be handled as a Task: strict decoding error: unknown field "metadata.description"

Success:

kubectl apply -f show-readme.yaml
task.tekton.dev/show-readme created

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

pavanstarmanwar commented 1 year ago

spec.description

Done @AlanGreene

pavanstarmanwar commented 1 year ago

/assign @geriom

pavanstarmanwar commented 1 year ago

@AlanGreene updated , thanks again

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)~~ [AlanGreene] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AlanGreene commented 1 year ago

/lgtm