tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

Get started with chains #530

Closed geriom closed 1 year ago

geriom commented 1 year ago

Changes

/closes #541

Previews:

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

bobcatfish commented 1 year ago

(fyi @chuangw6 this is probably relevant to your interests also)

/approve

tekton-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)~~ [bobcatfish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
geriom commented 1 year ago

@afrittoli Thanks for the review! I updated both links to the blog post.

avinal commented 1 year ago

It seems there is an issue with the diagram but it works fine on GitHub. See below image

---
title: Tekton Results Data Model 
---
graph BT
  B(TaskRun) --> |Record| A[Result]
  C(Log) --> |Record| A
  D(PipelineRun) --> |Record| A
geriom commented 1 year ago

Thank you @avinal for catching this. Can you please open a separate issue to track this? Mermaid diagrams seem a bit flaky and the error messages don't provide a lot of information. I'm going to look into that after this PR is merged.

afrittoli commented 1 year ago

/lgtm