search

tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

Tasks - "yaml" syntax highlighting #540

Closed michaelsatish closed 9 months ago

michaelsatish commented 1 year ago

Hello,

The "yaml" syntax highlighting is missing in the below sections.

  1. https://tekton.dev/docs/pipelines/tasks/#task-vs-clustertask
  2. https://tekton.dev/docs/pipelines/tasks/#defining-steps

Current syntax highlighting :

yaml apiVersion: tekton.dev/v1 kind: Pipeline metadata: name: demo-pipeline spec: tasks: - name: build-skaffold-web taskRef: 
resolver: cluster params: - name: kind value: task - name: name value: build-push - name: namespace value: default

How it should highlight:

apiVersion: tekton.dev/v1 
kind: Pipeline 
metadata: name: demo-pipeline 
spec: 
  tasks: 
    - name: build-skaffold-web 
       taskRef: 
         resolver: cluster 
       params: 
          - name: kind 
            value: task 
          - name: name 
            value: build-push 
          - name: namespace 
            value: default
AlanGreene commented 1 year ago

Thanks for reporting this @michaelsatish. It looks like it might be related to the use of tabs for the different API versions introduced in https://github.com/tektoncd/pipeline/pull/6414 (@chitrangpatel fyi)

I see the same issue on other pages which are also using the tabs, some examples: https://tekton.dev/docs/pipelines/taskruns/#tekton-bundles https://tekton.dev/docs/pipelines/pipelines/#tekton-bundles https://tekton.dev/docs/pipelines/pipelineruns/#mapping-serviceaccount-credentials-to-tasks

tekton-robot commented 11 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot commented 10 months ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot commented 9 months ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot commented 9 months ago

@tekton-robot: Closing this issue.

In response to [this](https://github.com/tektoncd/website/issues/540#issuecomment-1732369117): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen` with a justification. >Mark the issue as fresh with `/remove-lifecycle rotten` with a justification. >If this issue should be exempted, mark the issue as frozen with `/lifecycle frozen` with a justification. > >/close > >Send feedback to [tektoncd/plumbing](https://github.com/tektoncd/plumbing). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.