search

tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

Results - Broken Mermaid Charts #541

Closed michaelsatish closed 1 year ago

michaelsatish commented 1 year ago

Hello,

I was reading the Results documentation and noticed the below links has broken mermaid charts.

  1. https://tekton.dev/docs/results/#life-of-a-result
  2. https://tekton.dev/docs/results/#life-of-a-result
avinal commented 1 year ago

Thank you @michaelsatish, I was about to report this. @geriom from our discussion in slack it should work just fine. I also went through the docsy docs. The only requirement was Hugo version >=0.93, The website uses 0.107, so it fine there.

https://github.com/tektoncd/website/blob/471b58831215259f60faf6adefecbcaf9f622482/netlify.toml#L6

geriom commented 1 year ago

Thank you @michaelsatish

It seems that a recent change in Docsy broke mermaid. I'm adding back mermaid support in this PR, which includes a mermaid diagram that represents Tekton Chains. If you check the preview you can see the results diagrams rendering correctly.

Docsy is currently undergoing a massive upgrade to support bootstrap 5. Once the new Docsy release is out I'll update the site and revisit this change if necessary.