tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

Yaml not rendered correctly. #549

Closed geriom closed 8 months ago

geriom commented 1 year ago

The tabs in https://tekton.dev/docs/pipelines/tasks/ are not rendering the content correctly. It's probably as simple as changing the delimiter from {{% to {{< or the other way around.

AlanGreene commented 1 year ago

This was partially fixed on main, see https://github.com/tektoncd/pipeline/issues/6636 There are a few similar issues remaining, e.g. https://github.com/tektoncd/pipeline/issues/6697 and https://github.com/tektoncd/website/issues/540

chitrangpatel commented 1 year ago

https://github.com/tektoncd/pipeline/pull/6750 tries to fix this.

rh-hemartin commented 1 year ago

Was this solved? I still see image

on https://tekton.dev/docs/pipelines/tasks/

chitrangpatel commented 1 year ago

The PR that fixes it was merged. Although I'm not sure when the website will be updated. I wonder if its after the Tekton Pipelines next release since the fix was in that repo?

AlanGreene commented 1 year ago

It's fixed on main, you can access different releases from the 'Latest Versions' dropdown in the site header.

See for example: https://tekton.dev/vault/pipelines-main/tasks/

To show up in other versions the fix would need to be back-ported to their respective branches, or wait until the next release including the change to be added for the default version to be fixed.

tekton-robot commented 10 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale with a justification. Stale issues rot after an additional 30d of inactivity and eventually close. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

tekton-robot commented 9 months ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten with a justification. Rotten issues close after an additional 30d of inactivity. If this issue is safe to close now please do so with /close with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

tekton-robot commented 8 months ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen with a justification. Mark the issue as fresh with /remove-lifecycle rotten with a justification. If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

tekton-robot commented 8 months ago

@tekton-robot: Closing this issue.

In response to [this](https://github.com/tektoncd/website/issues/549#issuecomment-1792643315): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen` with a justification. >Mark the issue as fresh with `/remove-lifecycle rotten` with a justification. >If this issue should be exempted, mark the issue as frozen with `/lifecycle frozen` with a justification. > >/close > >Send feedback to [tektoncd/plumbing](https://github.com/tektoncd/plumbing). Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.