tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

Redirect /predicate/chains to Chains documentation. #562

Closed wlynch closed 8 months ago

wlynch commented 10 months ago

Changes

This sets up a redirect so for /predicate/chains to Chains documentation.

i.e. https://tekton.dev/predicate/chains/slsa/v2 -> https://github.com/tektoncd/chains/tree/main/docs/predicate/slsa/v2 (these pages don't actually exist yet).

This is a placeholder for SLSA predicate type documentation. We may try to figure out how to handle these better with the doc import process later on, but we need these to keep URL structure that AFAIK sync.py doesn't support well today. These URLs show up in Chains-generated SLSA predicates.

We do not need navigation for these URLs (we'll figure out if we want to add this later with the doc syncing).

See https://github.com/tektoncd/chains/pull/906 for more details.

Fixes #561

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

wlynch commented 8 months ago

@geriom @popcor255 ping for review 🙏 (or let me know if there's someone else I should get to review this)

tekton-robot commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geriom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)~~ [geriom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wlynch commented 8 months ago

Is there a reason for creating a _redirecs file instead of adding the redirects to netlify.toml?

Nope, no particular reason. We can rewrite this in netlify.toml if we want. 🤷

geriom commented 8 months ago

/lgtm