Closed wlynch closed 8 months ago
@geriom @popcor255 ping for review 🙏 (or let me know if there's someone else I should get to review this)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: geriom
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Is there a reason for creating a _redirecs file instead of adding the redirects to netlify.toml?
Nope, no particular reason. We can rewrite this in netlify.toml if we want. 🤷
/lgtm
Changes
This sets up a redirect so for /predicate/chains to Chains documentation.
i.e.
https://tekton.dev/predicate/chains/slsa/v2
->https://github.com/tektoncd/chains/tree/main/docs/predicate/slsa/v2
(these pages don't actually exist yet).This is a placeholder for SLSA predicate type documentation. We may try to figure out how to handle these better with the doc import process later on, but we need these to keep URL structure that AFAIK sync.py doesn't support well today. These URLs show up in Chains-generated SLSA predicates.
We do not need navigation for these URLs (we'll figure out if we want to add this later with the doc syncing).
See https://github.com/tektoncd/chains/pull/906 for more details.
Fixes #561
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
See the contribution guide for more details.