tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

"Speed Up Container Image Builds in Tekton Pipelines" blog post #571

Closed ggalloro closed 7 months ago

ggalloro commented 8 months ago

This is to add "Speed Up Container Image Builds in Tekton Pipelines" blog post.

Cross post from the article in CDF Blog: https://cd.foundation/blog/2023/10/12/speed-up-container-image-builds-tekton-pipelines/

afrittoli commented 8 months ago

Looking for a second review @AlanGreene @vdemeester

AlanGreene commented 8 months ago

Thanks @ggalloro. I agree with Andrea's comment, this should include a link to the original post.

Also looks like this relies on content from https://github.com/tektoncd/pipeline/pull/7312 being available. Since it points at the main branch rather than a particular commit / tag there's a risk that we'll end up with dead links in the blog post in future.

Would it make sense to include those files in the website repo alongside the blog post instead?

/hold

ggalloro commented 8 months ago

Thanks @AlanGreene will try to do that.

Any advice to which path to put the sample code in ?

AlanGreene commented 8 months ago

A sub-folder of the blog post location would make sense to keep it all together

ggalloro commented 8 months ago

Added a commit to this PR w example code under the blog folder.

Changed the links to example code in the post with absolute links as https://github.com/tektoncd/website/tree/main/content/en/blog/2023/speeding-up-container-image-builds-in-tekton-pipelines/tekton-speed-builds/

Added note with link to original post in CDF blog

@AlanGreene can you please review ?

ggalloro commented 7 months ago

Hi @AlanGreene @afrittoli is there any further action needed from my side to get this PR reviewed ? Many thanks !

tekton-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, AlanGreene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)~~ [AlanGreene,afrittoli] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AlanGreene commented 7 months ago

/hold cancel

afrittoli commented 7 months ago

🎉