tektoncd / website

Tekton Website
https://tekton.dev
Apache License 2.0
62 stars 149 forks source link

Update mermaid to fix Results data model diagram #588

Closed AlanGreene closed 4 months ago

AlanGreene commented 4 months ago

Changes

Related https://github.com/tektoncd/results/pull/708 /kind misc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

See the contribution guide for more details.

AlanGreene commented 4 months ago

/cc @afrittoli @geriom

avinal commented 4 months ago

Instead of just updating the mermaid, we should bump the docsy version. This will bring more features and fixes along with the mermaid fix. It was updated a long time ago, given the website uses docsy 0.6 and the latest is 0.8 (https://github.com/google/docsy/releases/tag/v0.8.0)

AlanGreene commented 4 months ago

@avinal I agree that we should update docsy however I don't currently have time to work on this, especially given the warning about significant breaking changes in 0.7. If someone else has time to work on this in the near future that would be great.

In the meantime this is a small targetted fix to resolve a current issue on the website affecting our users.

geriom commented 4 months ago

given the warning about significant breaking changes in 0.7. If someone else has time to work on this in the near future that would be great.

Yes, Docsy is now running on a newer version of bootstrap. I might have some time to look into this in late April, if someone wants to take a look sooner, I can share some useful links to help with the migration process.

tekton-robot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avinal, geriom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/tektoncd/website/blob/main/OWNERS)~~ [geriom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
geriom commented 4 months ago

/lgtm