search

tekul / jose-jwt

Haskell implementation of JOSE/JWT standards
BSD 3-Clause "New" or "Revised" License
35 stars 22 forks source link

Add Num Instance #33

Closed psibi closed 2 years ago

psibi commented 2 years ago

Required subtraction on IntDate for one of our validations we do.

tekul commented 2 years ago

Thanks. I'd like to rename this type eventually since the name annoys me (I think it was initially just created as a newtype to prevent orphan FromJSON/ToJSON instances for POSIXTime). It would be better called something like POSIXSeconds, possible with a type alias for the old name for compatibility.

I can merge this in the meantime though, but could you explain what the nix section in stack.yaml is for and whether it's appropriate here?

psibi commented 2 years ago

I can merge this in the meantime though, but could you explain what the nix section in stack.yaml is for and whether it's appropriate here?

Totally forgot about the nix section. The nix section is required to make it work in NixOS, but I think it's ignored in other distributions. I can remove it if you think so.

psibi commented 2 years ago

@tekul Gentle ping...

tekul commented 2 years ago

Thanks. Sorry for the delay. Kind of busy with other non-Haskell stuff. I edited out the specific nix version and committed the rest of the change.

psibi commented 2 years ago

Thank you!