Vitter-2112 commented 4 years ago

9

SetDemo already reviewed, nothing new, for #testing only

Vitter-2112 commented 4 years ago

is the pull request itself done in the way you wanted?

Rgds

VT

Gesendet: Sonntag, 24. Mai 2020 um 21:39 Uhr Von: "Sergey Lukichev" notifications@github.com An: "tel-ran-de/BE10-Basic" BE10-Basic@noreply.github.com Cc: "Vitter-2112" goryt@web.de, "Author" author@noreply.github.com Betreff: Re: [tel-ran-de/BE10-Basic] Test PR issue #9 (#19)

@sergeylukichev commented on this pull request.

In SetDemo/src/SetDemo.java:

LinkedList list=new LinkedList<>();

list.add("Petr");

list.add("Anna");

list.add("Maria");

list.add("Ivan");

list.add("Anna");

list.add("Petr");

list.add("Filip");

list.add("Anna");

list.add("George");

//System.out.println(list);

Set set= new HashSet<>();//inner class?

set.addAll(list);// Set allows no duplicates, consequently they will be eliminated by adding them to a set

System.out.println(set);

Definition of done: the task is solved as a method, which accepts some parameters and returns a result. There is a test, which proves that the method is correct for some basic use cases.

Your solution is just about showing that you know how to write some code using Set API. It is not enough.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

sergeylukichev commented 4 years ago

No, you still target tel-ran master, but we agreed the target should be the master of your repo.

tel-ran-de / BE10-Basic

Test PR issue #9 #19

9