search

tel-ran-de / BE10-Basic

Basic Java Group 10
1 stars 8 forks source link

Refactoring: split FileService to reading csv and saving an image #42

Open sergeylukichev opened 4 years ago

sergeylukichev commented 4 years ago

Contributes to https://github.com/tel-ran-de/BE10-Basic/issues/34

Currently, the FileService does 2 things: 

reads a CSV file, which contains images to apply an action to
saves a buffered image to a file on the disk

Consider splitting it into to service:

  1. CsvFileService, which is only responsible for reading a csv file
  2. ImageFileService, which is responsible for saving binary images to files, with proper names
Evgenij-Pavlenko commented 4 years ago

https://github.com/Evgenij-Pavlenko/TelranIdea/pull/42/commits/d938a819d5c271fdd3f3a54cf54665b45d635514